Skip to content

Add help for conversation/process service#14323

Merged
balloob merged 3 commits intohome-assistant:devfrom
stephanerosi:conversation
May 8, 2018
Merged

Add help for conversation/process service#14323
balloob merged 3 commits intohome-assistant:devfrom
stephanerosi:conversation

Conversation

@stephanerosi
Copy link
Copy Markdown
Contributor

@stephanerosi stephanerosi commented May 6, 2018

Description:

Add service description on service page

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@homeassistant homeassistant added cla-signed small-pr PRs with less than 30 lines. labels May 6, 2018
Comment thread homeassistant/components/services.yaml Outdated
@@ -1,5 +1,13 @@
# Describes the format for available component services

conversation:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't add more services to services.yaml. Instead, move conversation.py to conversation/__init__.py and create a new conversation/services.yaml

@stephanerosi
Copy link
Copy Markdown
Contributor Author

@balloob Ok, I made the changes.

Copy link
Copy Markdown
Contributor Author

@stephanerosi stephanerosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I update my PR with these changes

@balloob balloob merged commit ff01aa4 into home-assistant:dev May 8, 2018
stephanerosi added a commit to stephanerosi/home-assistant that referenced this pull request May 21, 2018
* Add help for conversation/process service

* Add logging to debug text received when service is called

* Move conversation to specific folder
@balloob balloob mentioned this pull request May 28, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
* Add help for conversation/process service

* Add logging to debug text received when service is called

* Move conversation to specific folder
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants